Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: support ConstItem() for expression (#10004) #10381

Merged
merged 3 commits into from
May 13, 2019
Merged

expression: support ConstItem() for expression (#10004) #10381

merged 3 commits into from
May 13, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented May 7, 2019

cherry-pick #10004 to 2.1

it needed by bugfix cherry-pick for #10064


This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented May 7, 2019

/run-all-test tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label May 7, 2019
@mahjonp
Copy link
Contributor

mahjonp commented May 8, 2019

/run-build-image

@jackysp
Copy link
Member

jackysp commented May 10, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor Author

lysu commented May 11, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@lysu
Copy link
Contributor Author

lysu commented May 13, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@jackysp jackysp merged commit 89bf55d into pingcap:release-2.1 May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants