Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add admin cleanup table lock syntax support #10423

Merged
merged 12 commits into from
Jul 10, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented May 10, 2019

What problem does this PR solve?

Related Parser PR: pingcap/parser#323.

Add cleanup table lock syntax:

ADMIN CLEANUP TABLE LOCK table_name1 [, table_name2...]

Cleanup table lock use to cleanup table locks. Normally won't use it. Just in case for session has not clean locks before exit.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

@crazycs520 crazycs520 changed the title Clean table lock *: add admin cleanup table lock syntax support May 10, 2019
@crazycs520 crazycs520 added type/new-feature require-LGT3 Indicates that the PR requires three LGTM. labels May 10, 2019
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #10423 into master will decrease coverage by 0.0679%.
The diff coverage is 83.3333%.

@@               Coverage Diff               @@
##             master     #10423       +/-   ##
===============================================
- Coverage   81.0432%   80.9753%   -0.068%     
===============================================
  Files           422        419        -3     
  Lines         89910      89363      -547     
===============================================
- Hits          72866      72362      -504     
+ Misses        11769      11768        -1     
+ Partials       5275       5233       -42

ddl/ddl_api.go Outdated Show resolved Hide resolved
ddl/ddl_api.go Show resolved Hide resolved
@crazycs520
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

planner/core/planbuilder.go Outdated Show resolved Hide resolved
ddl/ddl_api.go Outdated Show resolved Hide resolved
ddl/ddl_api.go Outdated Show resolved Hide resolved
ddl/ddl_api.go Outdated Show resolved Hide resolved
ddl/ddl_api.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 5, 2019
@crazycs520
Copy link
Contributor Author

@bb7133 PTAL

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor

LGTM

@crazycs520
Copy link
Contributor Author

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require-LGT3 Indicates that the PR requires three LGTM. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants