Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: recycle idle connection in tikv client (#10616) #10632

Merged
merged 3 commits into from
Jun 4, 2019
Merged

store/tikv: recycle idle connection in tikv client (#10616) #10632

merged 3 commits into from
Jun 4, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry pick from #10616

@tiancaiamao
store/tikv: recycle idle connection in tikv client (pingcap#10616)
a30148c 
if a tikv addr has been idle for a while, recycle its connection
@tiancaiamao
Copy link
Contributor Author

PTAL @disksing @hicqu

@disksing
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT1 Indicates that a PR has LGTM 1. priority/release-blocker This issue blocks a release. Please solve it ASAP. labels May 31, 2019
zz-jason
zz-jason previously approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2019
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

/run-integration-ddl-test

lysu
lysu approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 9501014 into pingcap:release-3.0 Jun 4, 2019
@tiancaiamao tiancaiamao deleted the idle-recycle-cherry branch May 26, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu approved these changes

@zz-jason zz-jason zz-jason left review comments

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @disksing @lysu @zz-jason