Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix issue that function dayname is incompatible with Mysql when doing arithmetic(#9975) #10732

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 6, 2019

cherry-pick for #9975

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 6, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990 qw4990 changed the title expression: fix issue that function dayname is incompatible with Mysql when doing arithmetic expression: fix issue that function dayname is incompatible with Mysql when doing arithmetic(#9975) Jun 6, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 6, 2019
zz-jason
zz-jason previously approved these changes Jun 6, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Jun 6, 2019

@qw4990 Please resolve conflicts

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 6, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 6, 2019

@zz-jason fixed.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 6, 2019
@zz-jason zz-jason merged commit 480bd62 into pingcap:release-2.1 Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants