Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, expression: disallow add stored generated columns through ALTER TABLE (#10758) #10808

Merged
merged 2 commits into from
Jun 17, 2019
Merged

ddl, expression: disallow add stored generated columns through ALTER TABLE (#10758) #10808

merged 2 commits into from
Jun 17, 2019

Conversation

tangenta
Copy link
Contributor

Cherry-pick #10758 to v3.0

@tangenta
Copy link
Contributor Author

/run-all-tests

crazycs520
crazycs520 reviewed Jun 14, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 14, 2019
jackysp
jackysp approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 23d8d2b into pingcap:release-3.0 Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tangenta @jackysp @crazycs520