Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: let flush privileges do nothing when skip-grant-table is configured (#10986) #11027

Merged
merged 3 commits into from
Jul 6, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #10986

…configured (pingcap#10986)

When skip-grant-table is enabled, privilege handle is not initialized, calling flush privileges
would meet nil pointer panic
@tiancaiamao
Copy link
Contributor Author

PTAL @zz-jason @jackysp

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests tikv=release-3.0 pd=release-3.0

@crazycs520
Copy link
Contributor

/run-common-test tikv=release-3.0 pd=release-3.0

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 6, 2019
@zz-jason zz-jason merged commit e2426c3 into pingcap:release-3.0 Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants