lock: add delay clean table lock when session close #11038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11038 +/- ##
================================================
- Coverage 81.0145% 80.9561% -0.0585%
================================================
Files 419 419
Lines 89732 89336 -396
================================================
- Hits 72696 72323 -373
- Misses 11773 11778 +5
+ Partials 5263 5235 -28 |
|
/run-all-tests |
winkyao
reviewed
Jul 4, 2019
config/config.toml.example
Outdated
| @@ -57,6 +57,9 @@ treat-old-version-utf8-as-utf8mb4 = true | |||
| # enable-table-lock is used to control table lock feature. Default is false, indicate the table lock feature is disabled. | |||
| enable-table-lock = false | |||
|
|
|||
| # delay-clean-table-lock is used to control delay release table lock when the abnormal situation. (Milliseconds) | |||
There was a problem hiding this comment.
is used to control delay release table lock when the abnormal situation. -> is used to control whether delayed-release the table lock in the abnormal situation.
crazycs520
commented
Jul 4, 2019
winkyao
approved these changes
Jul 4, 2019
|
/run-all-tests |
marsishandsome
pushed a commit
to marsishandsome/tidb
that referenced
this pull request
Jul 24, 2019
lzmhhh123
pushed a commit
to lzmhhh123/tidb
that referenced
this pull request
Jan 19, 2020
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Apr 28, 2020
bb7133
pushed a commit
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add
delay-clean-table-lockconfiguration to control delay clean table lock.It is used for
TiSpark.Before This PR:
The logic of
TiSparkto use the table lock is:The problem is, What if the session was closed by unexpected between step 3 and 4, It will cause some problem.
TiFlash need to delayed release table lock before do commit.
What is changed and how it works?
Add
sleepinsession.Closeifdelay-clean-table-lockhas been configed.Check List
Tests
Code changes
Side effects
Related changes