Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: handle unsigned primary key for fast analyze (#11074) #11099

Merged
merged 2 commits into from
Jul 6, 2019
Merged

executor: handle unsigned primary key for fast analyze (#11074) #11099

merged 2 commits into from
Jul 6, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jul 5, 2019

Cherry pick #11074
No conflicts.

@alivxxx alivxxx requested review from zz-jason and winoros July 5, 2019 08:55
winoros
winoros reviewed Jul 5, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lzmhhh123
lzmhhh123 approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT3 The PR has already had 3 LGTM. label Jul 6, 2019
@zz-jason zz-jason merged commit 731e426 into pingcap:release-3.0 Jul 6, 2019
@alivxxx alivxxx deleted the handle branch July 12, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@zz-jason zz-jason zz-jason approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alivxxx @zz-jason @winoros @lzmhhh123