Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix bugs related to TIDB_INLJ hint (#11253) #11362

Merged
merged 9 commits into from
Jul 23, 2019
Merged

planner: fix bugs related to TIDB_INLJ hint (#11253) #11362

merged 9 commits into from
Jul 23, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 22, 2019

cherry-pick #11253 to release-3.0

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 22, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jul 22, 2019
Merged
@sre-bot sre-bot added sig/planner SIG: Planner type/3.0 cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Jul 22, 2019
zz-jason
zz-jason reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/run-common-test
/run-integration-common-test

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2019
@zz-jason zz-jason requested a review from eurekaka July 23, 2019 01:42
lzmhhh123
lzmhhh123 approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123
Copy link
Contributor

/run-all-tests

@lzmhhh123 lzmhhh123 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2019
@foreyes
Copy link
Contributor

foreyes commented Jul 23, 2019

/run-all-tests

@eurekaka eurekaka merged commit db533f5 into pingcap:release-3.0 Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @zz-jason @lzmhhh123 @foreyes @eurekaka