executor: fix wrong partition boundary for window funcions #11637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/bugfix
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
@lamxTyler merge failed. |
Codecov Report
@@ Coverage Diff @@
## master #11637 +/- ##
===========================================
Coverage ? 81.4103%
===========================================
Files ? 435
Lines ? 94122
Branches ? 0
===========================================
Hits ? 76625
Misses ? 11997
Partials ? 5500 |
SunRunAway
reviewed
Aug 7, 2019
alivxxx
added
status/DNM
and removed
status/can-merge
1 task
ngaut
added
the
status/can-merge
|
/run-all-tests |
|
@lamxTyler merge failed. |
zz-jason
removed
the
status/can-merge
zz-jason
dismissed
lzmhhh123’s stale review
Can not merge now. need to be merged together with another PR
|
/run-all-tests |
|
/run-all-tests |
|
/run-common-test tidb-test=pr/872 |
|
/run-unit-test |
zz-jason
approved these changes
Aug 22, 2019
|
cherry pick to release-3.0 failed |
This was referenced Aug 22, 2019
SunRunAway
added a commit
to SunRunAway/tidb
that referenced
this pull request
Aug 22, 2019
…cherry-pick-of-pingcap#11637-upstream-release-3.0
ngaut
pushed a commit
that referenced
this pull request
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #11612
What is changed and how it works?
Previously, when we meet one new partition, the next row will also be added in
groupRows, which may cause wrong result since it was counted in previous partition. This PR fixes it by only processing the next partition after prevoius one finished.Check List
Tests
Code changes
Side effects
Related changes