Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add opt_rule_blacklist in mysql tables. (#11096) #11658

Merged
merged 4 commits into from
Aug 7, 2019
Merged

*: add opt_rule_blacklist in mysql tables. (#11096) #11658

merged 4 commits into from
Aug 7, 2019

Conversation

lzmhhh123
Copy link
Contributor

cherry-pick #11096 to release-3.0
*: add opt_rule_blacklist in mysql tables. (#11096)

jackysp
jackysp reviewed Aug 7, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 7, 2019
@lzmhhh123 lzmhhh123 requested a review from zz-jason August 7, 2019 10:26
alivxxx
alivxxx approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 7, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 7, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 7, 2019

@lzmhhh123 merge failed.

@lzmhhh123
Copy link
Contributor Author

/run-auto-merge

@sre-bot
Copy link
Contributor

sre-bot commented Aug 7, 2019

/run-all-tests

@sre-bot sre-bot merged commit eca09b1 into pingcap:release-3.0 Aug 7, 2019
@lzmhhh123 lzmhhh123 deleted the release-3.0-cherry-pick-11096 branch August 7, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zz-jason zz-jason zz-jason approved these changes

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lzmhhh123 @sre-bot @jackysp @zz-jason @alivxxx