Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix panic when execute change pump state(#11730) #11827

Merged
merged 2 commits into from
Aug 22, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

when execute sql like change pump to node_state ='paused' for node_id 'pump1', tidb will return error connection running loop panic

What is changed and how it works?

fix it
cherry pick from #11730

Check List

Tests

  • Unit test

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Aug 22, 2019

LGTM

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/PTAL labels Aug 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 22, 2019

Sorry @WangXiangUSTC, you don't have permission to trigger auto merge event on this branch.

@WangXiangUSTC WangXiangUSTC removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2019
@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 22, 2019

/run-all-tests

@sre-bot sre-bot merged commit 1cf66d7 into pingcap:release-3.0 Aug 22, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/pick_change_panic branch August 22, 2019 08:42
@XuHuaiyu XuHuaiyu changed the title executor: fix panic when execute change pump state executor: fix panic when execute change pump state(#11730) Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants