Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx/binloginfo: fix uncomment pre_split_regions ddl-querys in binlog (#11762) #12120

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry pick #11762.

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. type/3.0 cherry-pick status/can-merge Indicates a PR has been approved by a committer. and removed needs-cherry-pick-3.0 labels Sep 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

Sorry @bb7133, you don't have permission to trigger auto merge event on this branch.

@ngaut ngaut added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Sep 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

@crazycs520 merge failed.

@crazycs520
Copy link
Contributor Author

/run-unit-test

@ngaut ngaut merged commit cdf4566 into pingcap:release-3.0 Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/binlog status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants