Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support a hint to read from tiflash in planner #12479

Merged
merged 14 commits into from
Oct 11, 2019
Merged

planner: support a hint to read from tiflash in planner #12479

merged 14 commits into from
Oct 11, 2019

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

Support a hint to read from tiflash in planner.

What is changed and how it works?

It's almost same as other hints. But the tests are changed much.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to update the documentation

@codecov
Copy link

codecov bot commented Sep 29, 2019 •
edited
Loading

Codecov Report

Merging #12479 into master will decrease coverage by 0.0795%.
The diff coverage is 47.6635%.

@@               Coverage Diff                @@
##             master     #12479        +/-   ##
================================================
- Coverage   79.9548%   79.8752%   -0.0796%     
================================================
  Files           460        460                
  Lines        104010     103599       -411     
================================================
- Hits          83161      82750       -411     
- Misses        14776      14779         +3     
+ Partials       6073       6070         -3

winoros
winoros reviewed Sep 30, 2019
View reviewed changes
planner/core/logical_plan_builder.go Outdated Show resolved Hide resolved
planner/core/logical_plan_builder.go Outdated Show resolved Hide resolved
planner/core/logical_plans.go Outdated Show resolved Hide resolved
foreyes
foreyes reviewed Oct 8, 2019
View reviewed changes
planner/core/find_best_task.go Outdated Show resolved Hide resolved
planner/core/common_plans.go Outdated Show resolved Hide resolved
alivxxx
alivxxx reviewed Oct 8, 2019
View reviewed changes
planner/core/exhaust_physical_plans.go Show resolved Hide resolved
planner/core/task.go Outdated Show resolved Hide resolved
@Reminiscent Reminiscent removed their request for review October 9, 2019 09:01
foreyes
foreyes reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@foreyes foreyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foreyes foreyes added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2019
@SunRunAway SunRunAway requested review from foreyes and removed request for SunRunAway October 9, 2019 10:19
@foreyes foreyes removed their request for review October 9, 2019 13:38
@zz-jason zz-jason mentioned this pull request Oct 10, 2019
Closed
alivxxx
alivxxx approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2019
@lzmhhh123
Copy link
Contributor Author

/run-common-test tidb-test=pr/916

@lzmhhh123
Copy link
Contributor Author

/run-common-test tidb-test=pr/916
/run-integration-common-test tidb-test=pr/916

2 similar comments
@lzmhhh123
Copy link
Contributor Author

/run-common-test tidb-test=pr/916
/run-integration-common-test tidb-test=pr/916

@lzmhhh123
Copy link
Contributor Author

/run-common-test tidb-test=pr/916
/run-integration-common-test tidb-test=pr/916

@lzmhhh123 lzmhhh123 closed this Oct 11, 2019
@lzmhhh123 lzmhhh123 reopened this Oct 11, 2019
@lzmhhh123 lzmhhh123 added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 11, 2019

/run-all-tests

@lzmhhh123 lzmhhh123 merged commit 7ffa450 into pingcap:master Oct 11, 2019
@lzmhhh123 lzmhhh123 deleted the dev/support_access_from_flash_planner branch October 11, 2019 08:36
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@lzmhhh123 @XiaTianliang
planner: support a hint to read from tiflash in planner (pingcap#12479)
a3b6521
lzmhhh123 added a commit to lzmhhh123/tidb that referenced this pull request Jan 19, 2020
@lzmhhh123
planner: support a hint to read from tiflash in planner (pingcap#12479)
3e2b38e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foreyes foreyes foreyes left review comments

@alivxxx alivxxx alivxxx approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@qw4990 qw4990 Awaiting requested review from qw4990

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lzmhhh123 @sre-bot @winoros @alivxxx @foreyes