executor: do not return first row until the frame is completed. #12480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12480 +/- ##
================================================
- Coverage 79.8678% 79.7899% -0.0779%
================================================
Files 461 460 -1
Lines 103809 102172 -1637
================================================
- Hits 82910 81523 -1387
+ Misses 14809 14761 -48
+ Partials 6090 5888 -202 |
|
/run-all-tests |
SunRunAway
force-pushed
the
window-func
branch
from
4d799e4
to
134b1f1
Compare
|
/run-all-tests |
|
/run-all-tests |
2 similar comments
alivxxx
reviewed
Oct 8, 2019
lzmhhh123
reviewed
Oct 11, 2019
Co-Authored-By: Zhuomin(Charming) Liu <lzmhhh123@gmail.com>
lzmhhh123
reviewed
Oct 12, 2019
lzmhhh123
approved these changes
Oct 12, 2019
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
This was referenced Oct 12, 2019
sre-bot
added a commit
to SunRunAway/tidb
that referenced
this pull request
Oct 14, 2019
…upstream-release-3.0
sre-bot
pushed a commit
that referenced
this pull request
Oct 14, 2019
sre-bot
added a commit
to SunRunAway/tidb
that referenced
this pull request
Oct 14, 2019
…upstream-release-3.1
ngaut
pushed a commit
that referenced
this pull request
Oct 14, 2019
This was referenced Oct 16, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #12415.
What is changed and how it works?
In previous implementation,
windowExecreturns a chunk when a frame is fetched but not evaluated. After rewriting,windowExecreturns a chunk after a frame is finished evaluating.It makes the code simpler, and all the implementation of aggregation functions can reference the data in the frame. The bad side is it will increase the time of meeting first row.
I'll send a following PR(#12481) to revert the changes of copying data in #11678, if this is accepted by reviewers.
Check List
Tests
Code changes
Side effects
Related changes
Release note