planner: fill missing origin table name for DEFAULT() function

[Deardrops]

What problem does this PR solve?

Fix #12471, #13189, #13390

What is changed and how it works?

The reason why we get the unexpect error Field (a) doesn't have a default value is that we missing the origin table name when rewrite the expression contains DEFAULT() function.

In detail, when we assign value to column a by set a = default(b), TiDB will rewrite the assignment expression default(b). When it execute to evalDefaultExpr, It will do some check:

tidb/planner/core/expression_rewriter.go

Lines 1508 to 1514 in 41ac571

	if colExpr.OrigTblName.O == "" {
	// column is evaluated by some expressions, for example:
	// `select default(c) from (select (a+1) as c from t) as t0`
	// in such case, a 'no default' error is returned
	er.err = table.ErrNoDefaultValue.GenWithStackByArgs(colExpr.ColName)
	return
	}

If the OrigTblName in logicalplan.Schema is empty, TiDB think the column
name referenced by DEFAULT() function is not a real column name (it's an AsName), so it throw the error Field (a) doesn't have a default value.

To resolve this issue, we should fill the missing origin table name when build the logicPlan, after that, rewrite the assignment expression.

Another issue is TiDB cannot get the column name of subquery's subquery (#13390).To resolve this issue, we should keep the original table name of the subquery as far as possible. When buildResultNode(), if the origTableName in logic plan is not empty, we should keep it. otherwise, we should replace the empty origTableName by the tableName.

Check List

Tests

• Integration test

Side effects

• Possible performance regression

[codecov]

Codecov Report

Merging #12550 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12550   +/-   ##
===========================================
  Coverage   80.0488%   80.0488%           
===========================================
  Files           473        473           
  Lines        116725     116725           
===========================================
  Hits          93437      93437           
  Misses        15960      15960           
  Partials       7328       7328

[winoros]

In TiDB

mysql> show create table t1;
+-------+-------------------------------------------------------------------------------------------------------------+
| Table | Create Table                                                                                                |
+-------+-------------------------------------------------------------------------------------------------------------+
| t1    | CREATE TABLE `t1` (
  `f1` int(11) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin |
+-------+-------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)
mysql> select default(f1) from (select * from (select * from (select 1) f1) f1) f1;
ERROR 1054 (42S22): Unknown column 'f1' in 'field list'
mysql> select default(f1) from (select * from (select * from (select 1 as f1) t1) t1) t1;
+-------------+
| default(f1) |
+-------------+
|        NULL |
+-------------+
1 row in set (0.00 sec)

mysql> select default(f2) from (select * from (select * from (select 1 as f2) t1) t1) t1;
ERROR 1054 (42S22): Unknown column 'f2' in 'field_list'
mysql> select f2 from (select * from (select * from (select 1 as f2) t1) t1) t1;
+----+
| f2 |
+----+
|  1 |
+----+
1 row in set (0.00 sec)

In MySQL

mysql> select default(c1) from (select * from (select * from (select 1 as c1) t1) t1) t1;
+-------------+
| default(c1) |
+-------------+
|           0 |
+-------------+
1 row in set (0.00 sec)
mysql> select default(c2) from (select * from (select * from (select 1 as c2) t1) t1) t1;
+-------------+
| default(c2) |
+-------------+
|           0 |
+-------------+
1 row in set (0.00 sec)

i.e. Still use `originalTableName doesn't solve the key issue.

[winoros]

Also, if there's a table create table t2(f1 int(11) default 11);
And you run select default(f1) from (select * from (select * from (select * from t2) t1) t1) t1;
In TiDB, it would be NULL while MySQL is 1.

[Deardrops]

This PR need more discussion, The time is not ripe. So we close it.

[Deardrops]

create table t2(f1 int(11) default 11);
insert into t2 value ();
select default(f1) from (select * from t2) t1; # <-- 11
select default(f1) from (select * from (select * from t2) t1 ) t1; # <-- Error 1146: Table 'test.t1' doesn't exist

[Deardrops]

/run-all-tests

[sre-bot]

@wjhuang2016, @tangenta, @winoros, @wshwsh12, PTAL.

[sre-bot]

@wjhuang2016, @tangenta, @winoros, PTAL.

[Deardrops]

/run-all-tests

[winoros]

lgtm

[winoros]

/run-integration-common-test

[Deardrops]

@winoros thanks~

[sre-bot]

cherry pick to release-3.1 failed

[sre-bot]

cherry pick to release-3.0 failed

[sre-bot]

cherry pick to release-2.1 failed