planner: do not convert filter to range for table scan with tiflash #12682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #12682 +/- ##
================================================
- Coverage 79.9084% 79.8443% -0.0641%
================================================
Files 461 461
Lines 104168 103678 -490
================================================
- Hits 83239 82781 -458
+ Misses 14819 14811 -8
+ Partials 6110 6086 -24 |
|
@winoros The coprocessor in TiFlash can't support range scan. So they now always use the full range, the bench test will be added after the integrated test with them. |
ghost
requested review from
qw4990 and
SunRunAway
and removed request for
a team
|
Ok |
alivxxx
added
status/LGT2
|
Your auto merge job has been accepted, waiting for 12676, 12640 |
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As the title says.
What is changed and how it works?
Change the range and the filter conditions in
DataSource.getOriginalPhysicalTableScan.Check List
Tests
Side effects