Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: retry region request when tiflash store not found #12928

Merged
merged 3 commits into from
Oct 28, 2019
Merged

tikv: retry region request when tiflash store not found #12928

merged 3 commits into from
Oct 28, 2019

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

The region request for TiFlash returns an error when none TiFlash store found in the region cache. But sometimes the region has the TiFlash replica, the region cache will not update.

What is changed and how it works?

Make region cache invalid instead of returning the error.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Possible performance regression

@lzmhhh123 lzmhhh123 added type/enhancement The issue or PR belongs to an enhancement. component/tikv labels Oct 25, 2019
@codecov
Copy link

codecov bot commented Oct 25, 2019 •
edited
Loading

Codecov Report

Merging #12928 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12928   +/-   ##
===========================================
  Coverage   80.5231%   80.5231%           
===========================================
  Files           465        465           
  Lines        109643     109643           
===========================================
  Hits          88288      88288           
  Misses        14836      14836           
  Partials       6519       6519

jackysp
jackysp reviewed Oct 28, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lysu
lysu approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

/run-all-tests

@sre-bot sre-bot merged commit 5590f42 into pingcap:master Oct 28, 2019
@lzmhhh123 lzmhhh123 deleted the enhance/retry_when_none_flash_store_found branch October 28, 2019 06:51
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@lzmhhh123 @XiaTianliang
tikv: retry region request when tiflash store not found (pingcap#12928)
a649ca2
lzmhhh123 added a commit to lzmhhh123/tidb that referenced this pull request Jan 19, 2020
@lzmhhh123
tikv: retry region request when tiflash store not found (pingcap#12928)
e1e20eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@lysu lysu lysu approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees
No one assigned
Labels
component/tikv status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzmhhh123 @sre-bot @lysu @jackysp