planner, session: add isolation read with engine type #12997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12997 +/- ##
================================================
+ Coverage 80.0122% 80.0866% +0.0744%
================================================
Files 468 465 -3
Lines 109697 107757 -1940
================================================
- Hits 87771 86299 -1472
+ Misses 15174 14962 -212
+ Partials 6752 6496 -256 |
alivxxx
reviewed
Oct 30, 2019
zz-jason
reviewed
Oct 30, 2019
zz-jason
reviewed
Oct 30, 2019
lzmhhh123
changed the title
|
@lamxTyler Now we can't realize the isolation read by store label. So I change this PR. Please retake a look. |
zz-jason
reviewed
Oct 30, 2019
alivxxx
reviewed
Oct 30, 2019
zz-jason
reviewed
Oct 30, 2019
planner/core/integration_test.go
Outdated
|
|
||
| _, err = tk.Exec("select * from t") | ||
| c.Assert(err, NotNil) | ||
| c.Assert(err.Error(), Equals, "[planner:1815]Internal : Can't find a proper physical plan for this query") |
There was a problem hiding this comment.
The error message should be more friendly to the user. We should try our best to point out the reason and how to workaround.
| formatVal += "," | ||
| } | ||
| switch { | ||
| case strings.EqualFold(engine, kv.TiKV.Name()): |
There was a problem hiding this comment.
should we also trim the spaces around each item and remove the duplicated items? For example, users may set the variable this way:
set @@ tidb_isolation_read_engines = "tiflash, tikv, tiflash, tikv";
alivxxx
reviewed
Oct 31, 2019
zz-jason
reviewed
Oct 31, 2019
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/merge |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/run-mybatis-test |
|
/merge |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/run-unit-test |
hicqu
reviewed
Nov 8, 2019
| @@ -734,9 +734,9 @@ func (e *Explain) explainPlanInRowFormat(p Plan, taskType, indent string, isLast | |||
| var storeType string | |||
| switch x.StoreType { | |||
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support isolation read by engine type.
What is changed and how it works?
Filter access paths by engine type after getting all possible access paths.
Check List
Tests
Code changes
Side effects