-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv: fix a memory leak in the batchClient for the large transactions #14031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
added
type/enhancement
The issue or PR belongs to an enhancement.
type/bugfix
This PR fixes a bug.
needs-cherry-pick-3.0
labels
Dec 11, 2019
lysu
reviewed
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
coocood
approved these changes
Dec 11, 2019
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Dec 11, 2019
/run-all-tests |
@tiancaiamao merge failed. |
/run-integration-common-test |
Codecov Report
@@ Coverage Diff @@
## master #14031 +/- ##
===============================================
- Coverage 80.638% 80.1523% -0.4857%
===============================================
Files 482 482
Lines 123479 120780 -2699
===============================================
- Hits 99571 96808 -2763
- Misses 16187 16232 +45
- Partials 7721 7740 +19 |
cherry pick to release-3.0 in PR #14032 |
sre-bot
added a commit
that referenced
this pull request
Dec 12, 2019
Fix #13883 |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/can-merge
Indicates a PR has been approved by a committer.
type/bugfix
This PR fixes a bug.
type/enhancement
The issue or PR belongs to an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix a memory leak.
What is changed and how it works?
Change
xxx = xxx[:0]
to some deep reset operation.Check List
Tests
Run some large transactions severals and observe the heap pprof.
Side effects
Related changes
Release note