Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocktikv: add the missing ConflictCommitTS (#14064) #14080

Merged
merged 2 commits into from
Dec 16, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Dec 16, 2019

cherry-pick #14064 to release-3.0


Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

The ErrConflict filled the wrong conflict ts in mocktikv.

What is changed and how it works?

Fix it.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 16, 2019

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 16, 2019
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Dec 16, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 16, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 16, 2019

/run-all-tests

@sre-bot sre-bot merged commit b9ba3ef into pingcap:release-3.0 Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants