planner: do not filter access paths by isolation read for mysql.SystemDB
#14309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
francis0407 and
alivxxx
and removed request for
a team
alivxxx
reviewed
Jan 2, 2020
planner/core/logical_plan_builder.go
Outdated
| @@ -2536,7 +2536,9 @@ func (b *PlanBuilder) buildDataSource(ctx context.Context, tn *ast.TableName, as | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| possiblePaths, err = b.filterPathByIsolationRead(possiblePaths) | |||
| if dbName.L != mysql.SystemDB { | |||
There was a problem hiding this comment.
Can we put the check into the function? In case that someone else called the function but forgot the check.
zz-jason
reviewed
Jan 5, 2020
lzmhhh123
requested review from
AstroProfundis and
zz-jason
and removed request for
AstroProfundis
lzmhhh123
added
the
status/can-merge
|
/run-all-tests |
lzmhhh123
deleted the
bug-fix/do_not_filter_paths_by_isolation_for_system_db
branch
lidezhu
pushed a commit
to lidezhu/tidb
that referenced
this pull request
Jan 7, 2020
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After
set global tidb_isolation_read_engines="tiflash", then restart tidb-server. The bootstrap can't finish because of some system DB's queries. It only can accessTiKV.What is changed and how it works?
Check the DB name whether is
mysql.SystemDBbefore filter access paths by isolation read.Check List
Tests