config: add server level isolation read config #14440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
eurekaka and
winoros
and removed request for
a team
eurekaka
reviewed
Jan 15, 2020
config/config.toml.example
Outdated
| [isolation-read] | ||
| # engines means allow the tidb server read data from which types of engines. options: "tikv", "tiflash", "tidb". | ||
| engines = ["tikv", "tiflash", "tidb"] | ||
| # labels means allow the tidb server read data from which labels. Empty set means all labels are allowed. |
There was a problem hiding this comment.
Could you explain more on the purpose of labels in the comment? or the use cases of the labels?
alivxxx
reviewed
Jan 16, 2020
winoros
reviewed
Jan 16, 2020
|
/rebuild |
lzmhhh123
force-pushed
the
dev/add_server_isolation_read
branch
from
0159d0e
to
69199e9
Compare
|
/rebuild |
|
/run-unit-test |
alivxxx
approved these changes
Jan 19, 2020
alivxxx
added
status/LGT2
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/merge |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/run-all-tests |
|
/rebuild |
|
/merge |
|
Your auto merge job has been accepted, waiting for 14530 |
|
/run-all-tests |
|
/run-unit-test |
|
@lzmhhh123 merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For isolation read. We have the global and session variable
tidb_isolation_read_enginesto control. But we can't control specific tidb-server to set isolation read. So we need a server-level config to control the isolation.What is changed and how it works?
When both the server-level isolation read and session-level isolation read exists. The access paths should be filtered by both of them.
Check List
Tests
Code changes
Related changes