Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix some select condition do not filter by tiflash #14502

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

As the title says.

What is changed and how it works?

The origin condition push-down check for tiflash is only in predicates_push_down for store hint. That not enough. We should make the isolation read and CBO to filter the push-down conditions too.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has persistent data change

@lzmhhh123 lzmhhh123 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Jan 16, 2020
@lzmhhh123 lzmhhh123 requested a review from a team as a code owner January 16, 2020 07:45
@ghost ghost requested review from eurekaka and winoros and removed request for a team January 16, 2020 07:45
@lzmhhh123
Copy link
Contributor Author

/rebuild

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@winoros
Copy link
Member

winoros commented Jan 16, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2020

/run-all-tests

@sre-bot sre-bot merged commit cd9c65a into pingcap:master Jan 16, 2020
@lzmhhh123 lzmhhh123 deleted the bug-fix/ban_cast_for_flash branch January 16, 2020 08:24
lzmhhh123 added a commit to lzmhhh123/tidb that referenced this pull request Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants