*: Make column test stable and fix prepare statement issue #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
shenli
reviewed
Jan 15, 2017
| @@ -561,7 +565,7 @@ func (s *session) DropPreparedStmt(stmtID uint32) error { | |||
| if _, ok := vars.PreparedStmts[stmtID]; !ok { | |||
| return executor.ErrStmtNotFound | |||
| } | |||
| delete(vars.PreparedStmts, stmtID) | |||
| vars.RetryInfo.DroppedPreparedStmtIDs = append(vars.RetryInfo.DroppedPreparedStmtIDs, stmtID) | |||
There was a problem hiding this comment.
In retry, ExecutePreparedStmt will execute with the same stmtID, so we should not dropping the preparedStmts until finished the transaction, dropping it in ClearRetryInfo.
There was a problem hiding this comment.
Will we retry prepare statement? Or we only retry execute statement?
There was a problem hiding this comment.
We only retry execute statement.
Session.PrepareStmt do not add statement history.
|
LGTM |
coocood
approved these changes
Jan 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddl: make column test stable
*: fix prepare statement issue when retrying