Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/types: convertToMysqlTime will truncate hh:mm:ss part for Date type #2808

Merged
merged 1 commit into from
Mar 10, 2017

Conversation

tiancaiamao
Copy link
Contributor

Convert to Date should truncate the hh:mm:ss part.

Fix bug:

mysql> select date("2016-11-11 11:00:00") = date("2016-11-11 12:00:00");
+-----------------------------------------------------------+
| date("2016-11-11 11:00:00") = date("2016-11-11 12:00:00") |
+-----------------------------------------------------------+
|                                                         0 |
+-----------------------------------------------------------+
1 row in set (0.00 sec)

@tiancaiamao
Copy link
Contributor Author

@andelf @coocood @shenli

@hanfei1991
Copy link
Member

LGTM

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit b8b84dd into master Mar 10, 2017
@coocood coocood deleted the tiancaiamao/truncate-date branch March 10, 2017 11:45
@TennyZhuang TennyZhuang mentioned this pull request Dec 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants