Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binlog: update binlog status from Skippping to On when recover binlog #32173

Merged
merged 9 commits into from
Nov 14, 2022
Merged

binlog: update binlog status from Skippping to On when recover binlog #32173

merged 9 commits into from
Nov 14, 2022

Conversation

joccau
Copy link
Member

@joccau joccau commented Feb 8, 2022 •
edited
Loading

Signed-off-by: joccau zak.zhao@pingcap.com

What problem does this PR solve?

Issue Number: close #32172

Problem Summary: As title

What is changed and how it works?

It need to update binlog_status when recover binlog.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@joccau
update binlog status when disable skip binlog
d19b8cc 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Feb 8, 2022
@joccau
Copy link
Member Author

joccau commented Feb 8, 2022

/cc @glorv @lichunzhu @kennytm @3pointer PTAL

@ti-chi-bot
Copy link
Member

@joccau: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @glorv @lichunzhu @kennytm @3pointer PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joccau
Copy link
Member Author

joccau commented Feb 8, 2022

/hold
I need to test it, but reviewers can review code firstly.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Feb 8, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/48a2dc792b7c3033685c80822978d262fe228bb7

lichunzhu
lichunzhu approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2022
@joccau joccau changed the title binglog: update binlog status from Skippping to On when recover binlog binlog: update binlog status from Skippping to On when recover binlog Feb 9, 2022
@joccau
Copy link
Member Author

joccau commented Feb 9, 2022

/component binlog

@glorv
Copy link
Contributor

glorv commented Feb 9, 2022

/cc @jackysp PTAL

@ti-chi-bot
Copy link
Member

@glorv: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jackysp PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jackysp
jackysp approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 9, 2022
@joccau
check returned errno
86c8b7f 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2022
@jackysp jackysp removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2022
@jackysp
Copy link
Member

jackysp commented Nov 14, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit 192eae2 into pingcap:master Nov 14, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39111.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2022
Open
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39112.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39113.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39114.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39115.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39116.

This was referenced Nov 14, 2022
Closed
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39117.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39118.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39119.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39120.

@sre-bot
Copy link
Contributor

sre-bot commented Nov 14, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 43 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 39 tests passed 20 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 10 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 1 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 51 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@joccau joccau deleted the fix-binlog-status branch November 28, 2022 12:58
ti-chi-bot added a commit that referenced this pull request Jan 10, 2023
@ti-chi-bot
binlog: update binlog status from Skippping to On when recover binlog (…
1e39e33 
…#32173) (#39113)

close #32172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@glorv glorv Awaiting requested review from glorv

@3pointer 3pointer Awaiting requested review from 3pointer

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
component/binlog needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binlog: Can not recover binlogStatus in tidb-server from Skipping to On
8 participants
@joccau @ti-chi-bot @sre-bot @glorv @kennytm @lichunzhu @jackysp @hawkingrei