Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: modify default unique index name #39145

Merged
merged 4 commits into from
Nov 15, 2022
Merged

ddl: modify default unique index name #39145

merged 4 commits into from
Nov 15, 2022

Conversation

wxbty
Copy link
Contributor

@wxbty wxbty commented Nov 15, 2022

What problem does this PR solve?

Make the default name of the unique index consistent with mysql

Issue Number: close #39080

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test TestIssue39080
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

x-shadow-man and others added 2 commits November 15, 2022 10:28
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2022
@wxbty
Copy link
Contributor Author

wxbty commented Nov 15, 2022

/cc @xhebox @wjhuang2016

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 15, 2022
@lance6716
Copy link
Contributor 

run test [alter_table_PK] err: sql:SHOW INDEX FROM t1;: failed to run query
"SHOW INDEX FROM t1;"
 around line 52,
we need(340):
SHOW INDEX FROM t1;
Table	Non_unique	Key_name	Seq_in_index	Column_name	Collation	Cardinality	Sub_part	Packed	Null	Index_type	CommentIndex_comment	Visible	Expression	Clustered
t1	0	PRIMARY	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	0	PRIMARY	2	User	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	1	host_2	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO

but got(340):
SHOW INDEX FROM t1;
Table	Non_unique	Key_name	Seq_in_index	Column_name	Collation	Cardinality	Sub_part	Packed	Null	Index_type	CommentIndex_comment	Visible	Expression	Clustered
t1	0	PRIMARY	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	0	PRIMARY	2	User	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	1	Host_2	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO

one of our internal test is failed, PTAL @xhebox

@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022 

run test [alter_table_PK] err: sql:SHOW INDEX FROM t1;: failed to run query
"SHOW INDEX FROM t1;"
 around line 52,
we need(340):
SHOW INDEX FROM t1;
Table	Non_unique	Key_name	Seq_in_index	Column_name	Collation	Cardinality	Sub_part	Packed	Null	Index_type	CommentIndex_comment	Visible	Expression	Clustered
t1	0	PRIMARY	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	0	PRIMARY	2	User	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	1	host_2	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO

but got(340):
SHOW INDEX FROM t1;
Table	Non_unique	Key_name	Seq_in_index	Column_name	Collation	Cardinality	Sub_part	Packed	Null	Index_type	CommentIndex_comment	Visible	Expression	Clustered
t1	0	PRIMARY	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	0	PRIMARY	2	User	A	0	NULL	NULL		BTREE			YES	NULL	NO
t1	1	Host_2	1	Host	A	0	NULL	NULL		BTREE			YES	NULL	NO

one of our internal test is failed, PTAL @xhebox

Okay... Let me fix it.

@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022

/run-mysql-test tidb-test=pr/2015

1 similar comment
@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022

/run-mysql-test tidb-test=pr/2015

@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022

/run-mysql-test tidb-test=pr/2015

@wjhuang2016
Copy link
Member

/run-mysql-test

@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022

/run-mysql-test tidb-test=pr/2015

3 similar comments
@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022

/run-mysql-test tidb-test=pr/2015

@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022

/run-mysql-test tidb-test=pr/2015

@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022

/run-mysql-test tidb-test=pr/2015

@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022

/run-mysql-test tidb-test=pr/2015

@xhebox
Copy link
Contributor

xhebox commented Nov 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 57090c0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2022
@ti-chi-bot ti-chi-bot merged commit 661a6b6 into pingcap:master Nov 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 15, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 38, total 39 23 min New failing
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 8, success 9, total 17 15 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 2, success 4, total 6 43 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 10 min Existing failure
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 44 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 1 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 35 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@Mini256 Mini256 mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@xhebox xhebox xhebox approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The name of the generated unique key is not consistent with mysql
6 participants
@wxbty @ti-chi-bot @lance6716 @xhebox @wjhuang2016 @sre-bot