doc: add batch coprocessor rfc #39362
Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
docs/design/2022-11-23-batch-cop.md
Outdated
| Usually, the IndexLookUp executor may have an index worker which tries to read index keys and handles | ||
| according to the index filter conditions. Each time it fetches enough handle data, it would create a | ||
| coprocessor table task and send it to the table workers. The handle data size limit could be configured | ||
| by the [tidb_index_lookup_size](https://docs.pingcap.com/zh/tidb/dev/system-variables#tidb_index_lookup_size) |
There was a problem hiding this comment.
Use English link instead: https://docs.pingcap.com/tidb/dev/system-variables#tidb_index_lookup_size
docs/design/2022-11-23-batch-cop.md
Outdated
| by the [tidb_index_lookup_size](https://docs.pingcap.com/zh/tidb/dev/system-variables#tidb_index_lookup_size) | ||
| system variable. | ||
|
|
||
| When the table worker gets a coprocessor task, it would split the handle ranges according to the region |
There was a problem hiding this comment.
| When the table worker gets a coprocessor task, it would split the handle ranges according to th�e region | |
| When the table worker gets a coprocessor task, it would split the handle ranges according to the region |
docs/design/2022-11-23-batch-cop.md
Outdated
| there are region errors or other errors processing batch tasks, rescheduling the cop tasks or | ||
| reporting errors to the upper layer. | ||
|
|
||
| Note if the `keepOrder` is quired, the partial query result could not be sent back until all the reads |
docs/design/2022-11-23-batch-cop.md
Outdated
| … | ||
|
|
||
| // Store the batched tasks belonging to other regions. | ||
| repeated region_tasks = 11; |
There was a problem hiding this comment.
The repeated type is missing.
docs/design/2022-11-23-batch-cop.md
Outdated
| message Response { | ||
| … | ||
| // The returned region error handling batch tasks. | ||
| repeated errorpb.Error region_errors = 13; |
There was a problem hiding this comment.
Need to collect errors with region id or task info. e.g., 100 region tasks request got 2 errors(the first and last), we need to tell TiDB which tasks need to be retried.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #39362 +/- ##
================================================
+ Coverage 70.5286% 73.4101% +2.8814%
================================================
Files 1465 1056 -409
Lines 433686 335891 -97795
================================================
- Hits 305873 246578 -59295
+ Misses 108604 73518 -35086
+ Partials 19209 15795 -3414 |
|
@cfzjywxk: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/merge |
|
@cfzjywxk: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, you06, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@cfzjywxk: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Yilin Chen <sticnarf@gmail.com>
Co-authored-by: ekexium <eke@fastmail.com>
Co-authored-by: ekexium <eke@fastmail.com>
Co-authored-by: ekexium <eke@fastmail.com>
cfzjywxk
force-pushed
the
batch_cop_rfc
branch
from
b732365
to
d4cb1f3
Compare
What problem does this PR solve?
Issue Number: ref #39361
Problem Summary:
The design docuement.
What is changed and how it works?
Check List
Tests
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.