Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: improve log messages #39376

Merged
merged 4 commits into from
Nov 29, 2022
Merged

ddl: improve log messages #39376

merged 4 commits into from
Nov 29, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 24, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2022
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2022
@tangenta
Copy link
Contributor

tangenta commented Nov 24, 2022 •
edited
Loading

Please also update the usages in following logs:

[ddl] run reorg job done
[ddl] switch metadata lock feature
[ddl] SwitchConcurrentDDL
[autoid client] AllocAutoID grpc error, reconnect

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2022
@hawkingrei
Copy link
Member Author

Please also update the usages in following logs:

[ddl] run reorg job done
[ddl] switch metadata lock feature
[ddl] SwitchConcurrentDDL
[autoid client] AllocAutoID grpc error, reconnect

All have been updated.

tangenta
tangenta reviewed Nov 24, 2022
View reviewed changes
ddl/index.go Outdated Show resolved Hide resolved
@tangenta tangenta changed the title ddl: improve log in the tryFallbackToTxnMerge ddl: improve log message Nov 29, 2022
@tangenta tangenta changed the title ddl: improve log message ddl: improve log messages Nov 29, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2022
@hawkingrei
ddl: improve log in the tryFallbackToTxnMerge
1e3bcd2 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
improve log again
b17f981 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
e027c99 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
remove bazel config for remote
ede027e 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 29, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ede027e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 29, 2022
@hawkingrei
Copy link
Member Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 9689b47 into pingcap:master Nov 29, 2022
@hawkingrei hawkingrei deleted the improve_log branch November 29, 2022 09:16
@sre-bot
Copy link
Contributor

sre-bot commented Nov 29, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [3] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 1 min 3 sec Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 28 min Fixed
idc-jenkins-ci-tidb/sqllogic-test-2 ✅ all 28 tests passed 7 min 53 sec Fixed
idc-jenkins-ci-tidb/sqllogic-test-1 ✅ all 26 tests passed 7 min 2 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 35 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 4 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 5 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@tangenta tangenta tangenta approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkingrei @ti-chi-bot @tangenta @sre-bot @Defined2014