Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add global variable to control ttl syntax #39483

Merged
merged 6 commits into from
Dec 1, 2022
Merged

parser: add global variable to control ttl syntax #39483

merged 6 commits into from
Dec 1, 2022

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #39482

Problem Summary:

It's a little embarassing and anti-pattern, but works well. It returns a syntax error when the user submits a statement with TTL related syntax. And while developing, we could turn on the variable to run test and build a test server binary.

What is changed and how it works?

  1. TTLFeatureGate variable is added in parser pkg to control the support for TTL syntax.
  2. Modify some existing tests to set this variable to true.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Remove support for TTL syntax

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2022
@YangKeao YangKeao force-pushed the add-feature-gate-for-ttl branch 2 times, most recently from ac2942b to 558590a Compare November 30, 2022 06:41
@YangKeao YangKeao requested review from lcwangchao and hawkingrei and removed request for lcwangchao November 30, 2022 06:53
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
@YangKeao
Copy link
Member Author

/run-build

@YangKeao YangKeao force-pushed the add-feature-gate-for-ttl branch 2 times, most recently from 796688b to 5a07bba Compare November 30, 2022 09:28
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5a07bba04280999cb020c36d79b8a52d6bb34924

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@hawkingrei
Copy link
Member

/run-check_dev_2

1 similar comment
@YangKeao
Copy link
Member Author

/run-check_dev_2

@YangKeao
Copy link
Member Author

/run-unit-test

@lcwangchao
Copy link
Collaborator

/run-check_dev_2
/run-unit-test

1 similar comment
@YangKeao
Copy link
Member Author

YangKeao commented Dec 1, 2022

/run-check_dev_2
/run-unit-test

@YangKeao
Copy link
Member Author

YangKeao commented Dec 1, 2022

/run-check_dev_2
/run-check_dev
/run-build

@ti-chi-bot
Copy link
Member

@YangKeao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Dec 1, 2022

/run-check_dev

@YangKeao
add global variable to control ttl syntax
80ea263 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

YangKeao commented Dec 1, 2022

/run-unit-test

@YangKeao
Copy link
Member Author

YangKeao commented Dec 1, 2022

@lcwangchao Could you help me to merge (/merge) this PR? It seems that after solved the conflict, the bot cancel the merge 🤔

@lcwangchao
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9c73471

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@ti-chi-bot ti-chi-bot merged commit 6a4b909 into pingcap:master Dec 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 1, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 1, success 25, total 26 6 min 22 sec New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 1 hr 3 min Existing failure
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 25 min Existing failure
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 36 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 12 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 3 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 51 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 32 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add feature gate for ttl syntax
5 participants
@YangKeao @ti-chi-bot @hawkingrei @lcwangchao @sre-bot