Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: Do not run telemetry loops when it's disabled in config #40156

Merged
merged 5 commits into from
Dec 28, 2022
Merged

session: Do not run telemetry loops when it's disabled in config #40156

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5187ce
Do not run telemetry loops when it's disabled in config
sunxiaoguang Dec 24, 2022
366673c
Merge branch 'master' into do_not_run_telemetry_when_disable_in_config
ti-chi-bot Dec 28, 2022
96efc42
Merge branch 'master' into do_not_run_telemetry_when_disable_in_config
ti-chi-bot Dec 28, 2022
f5c6bf2
Merge branch 'master' into do_not_run_telemetry_when_disable_in_config
ti-chi-bot Dec 28, 2022
c2c0782
Merge branch 'master' into do_not_run_telemetry_when_disable_in_config
ti-chi-bot Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions session/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3373,10 +3373,14 @@ func BootstrapSession(store kv.Storage) (*domain.Domain, error) {
if dom.GetEtcdClient() != nil {
// We only want telemetry data in production-like clusters. When TiDB is deployed over other engines,
// for example, unistore engine (used for local tests), we just skip it. Its etcd client is nil.
go func() {
dom.TelemetryReportLoop(ses[5])
dom.TelemetryRotateSubWindowLoop(ses[5])
}()
if config.GetGlobalConfig().EnableTelemetry {
// There is no way to turn telemetry on with global variable `tidb_enable_telemetry`
// when it is disabled in config. See IsTelemetryEnabled function in telemetry/telemetry.go
go func() {
dom.TelemetryReportLoop(ses[5])
dom.TelemetryRotateSubWindowLoop(ses[5])
}()
}
}

planReplayerWorkerCnt := config.GetGlobalConfig().Performance.PlanReplayerDumpWorkerConcurrency
Expand Down