-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup: fix retry of fine-grained backup (#43252) #43302
backup: fix retry of fine-grained backup (#43252) #43302
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: hillium <yujuncen@pingcap.com>
b6e66d0
to
83fa48f
Compare
/retest-required |
/test |
@tonyxuqqi: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test mysql-test |
@tonyxuqqi: No presubmit jobs available for pingcap/tidb@release-6.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tonyxuqqi: No presubmit jobs available for pingcap/tidb@release-6.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/merge |
@tonyxuqqi: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Leavrth, tonyxuqqi, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This is an automated cherry-pick of #43252
What problem does this PR solve?
Issue Number: close #43236
Problem Summary:
We are using the
tikv.Backoffer
to implement retry. Which isn't so customizable hence we cannot fully control the printed error messages and back off duration.What is changed and how it works?
This PR added a new structure
RetryWithBackoffer
to adapt the retry logic with the TiDB backoffer logic, at the same time it has enhanced the error message.This PR will also increase the max retry time of fine-grained backup. The reason is simple: given it begins the fine-grained backup, there must be some problems in the cluster. We need to be more patient.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.