Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Support normal left/right outer MPPTask join with other condition to use either side as build side #43355

Merged
merged 5 commits into from
Apr 27, 2023
Merged

planner: Support normal left/right outer MPPTask join with other condition to use either side as build side #43355

merged 5 commits into from
Apr 27, 2023

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Apr 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43347

Problem Summary:

What is changed and how it works?

Add support only for normal ones: non-cross, non-nullAware joins.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@yibin87
Support non-cross non-null_aware left/right outer join with other con…
af3c60a 
…ditions to use either side as build side

Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 24, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 24, 2023

hold until pingcap/tiflash#7344 is merged.

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 24, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 24, 2023

/cc @windtalker @SeaRise

@ti-chi-bot ti-chi-bot bot requested review from SeaRise and windtalker April 24, 2023 07:07
@yibin87
Little refact
b6a838c 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Update utest result
4bfb903 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 24, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 26, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2023
SeaRise
SeaRise approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2023
@yibin87
Refact logic
dce8ced 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Update comments
90f04c8 
Signed-off-by: yibin <huyibin@pingcap.com>
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Apr 26, 2023
Merged
12 tasks
windtalker
windtalker approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2023
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 27, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 90f04c8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit 822767b into pingcap:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@SeaRise SeaRise SeaRise approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow MPPTask to use either side as build side for left/right outer join
3 participants
@yibin87 @windtalker @SeaRise