Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tables: split partiton test #46252

Merged
merged 3 commits into from
Aug 28, 2023
Merged

tables: split partiton test #46252

merged 3 commits into from
Aug 28, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 21, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #44940

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 21, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Merging #46252 (6e1a12f) into master (66ddb7b) will decrease coverage by 0.3230%.
Report is 15 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46252        +/-   ##
================================================
- Coverage   73.3963%   73.0733%   -0.3230%     
================================================
  Files          1295       1322        +27     
  Lines        393622     403893     +10271     
================================================
+ Hits         288904     295138      +6234     
- Misses        86337      90272      +3935     
- Partials      18381      18483       +102
Flag Coverage Δ
integration 25.8996% <ø> (?)
unit 73.7477% <ø> (+0.3514%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0741% <ø> (+0.0108%) ⬆️
br 49.1193% <ø> (-3.2153%) ⬇️

mjonss
mjonss reviewed Aug 21, 2023
View reviewed changes
table/tables/testutil.go
Comment on lines +19 to 20
// SwapReorgPartFields swaps the reorganizePartitions field of two partitioned tables. used in tests.
func SwapReorgPartFields(src, dst table.Table) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving from a *_test.go file pattern to testutil.go, would not that mean that this function now also gets exported in non-test context?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible for other developers to misuse the function. the best method is to move it into the partition_test. but I found it needs to change more private functions into public.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most important thing is to make partitionedTable public.

@hawkingrei
tables: split partiton test
1e4bcf5 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
tables: split partiton test
e8a582a 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
6e1a12f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-25 06:44:21.648987582 +0000 UTC m=+1477426.198003569: ☑️ agreed by lance6716.
  • 2023-08-28 08:10:28.248782505 +0000 UTC m=+1741792.797798488: ☑️ agreed by mjonss.

@ti-chi-bot ti-chi-bot bot merged commit e7e9fb6 into pingcap:master Aug 28, 2023
16 of 18 checks passed
@hawkingrei hawkingrei deleted the split_tables branch August 28, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@mjonss mjonss mjonss approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkingrei @lance6716 @mjonss