Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: less extensive reorganize partition tests #46459

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Aug 28, 2023

What problem does this PR solve?

Issue Number: close #46263 , close #46262 , close #46260

Problem Summary:
The test does several dml statements in each of the DDL state changes, and for different types of partitioning, resulting in long running tests. I have disabled most combinations and limited it to smaller set of data.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2023
@tiprow
Copy link

tiprow bot commented Aug 28, 2023

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjonss
Copy link
Contributor Author

mjonss commented Aug 28, 2023

/retest

@tiprow
Copy link

tiprow bot commented Aug 28, 2023

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjonss
Copy link
Contributor Author

mjonss commented Aug 28, 2023

/ok-to-test

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #46459 (a508c1e) into master (e7e9fb6) will decrease coverage by 0.6224%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46459        +/-   ##
================================================
- Coverage   73.4146%   72.7922%   -0.6224%     
================================================
  Files          1299       1320        +21     
  Lines        393939     400673      +6734     
================================================
+ Hits         289209     291659      +2450     
- Misses        86354      90585      +4231     
- Partials      18376      18429        +53     
Flag Coverage Δ
integration 25.7151% <ø> (?)
unit 73.4700% <ø> (+0.0553%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0633% <ø> (ø)
br 48.0270% <ø> (-4.3084%) ⬇️

@mjonss mjonss changed the title test: less extensive tests test: less extensive reorganize partition tests Aug 28, 2023
@mjonss mjonss requested a review from hawkingrei August 28, 2023 14:15
@hawkingrei
Copy link
Member

/test all

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-29 02:05:01.180902324 +0000 UTC m=+1806265.729918313: ☑️ agreed by hawkingrei.
  • 2023-08-29 02:14:41.299293769 +0000 UTC m=+1806845.848309757: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit 54f15a4 into pingcap:master Aug 29, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants