Makefile: add gotag for make server_check #51057

winoros · 2024-02-07T11:48:55Z

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

There's some error check enabled by gotag intest.

And we're moving tests from Golang's unit test to the integration tests. We need to use the binary which is compiled with the gotag.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

codecov · 2024-02-07T12:05:16Z

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.1887%. Comparing base (d99d445) to head (201d828).

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #51057         +/-   ##
=================================================
- Coverage   72.9567%   57.1887%   -15.7680%     
=================================================
  Files          1611       1771        +160     
  Lines        447502     670719     +223217     
=================================================
+ Hits         326483     383576      +57093     
- Misses       100925     262122     +161197     
- Partials      20094      25021       +4927

Flag	Coverage Δ
integration	`37.1686% <89.7435%> (?)`
unit	`71.9951% <89.7435%> (-0.0719%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9567% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`52.1107% <ø> (+6.3188%)`	⬆️

winoros · 2024-02-08T05:06:53Z

It's so surprising that some tests failed when we added the gotags.
I'll check it later.

winoros · 2024-02-18T16:41:17Z

/retest

okJiang

Maybe need a issue

ti-chi-bot · 2024-02-26T10:25:11Z

[LGTM Timeline notifier]

Timeline:

2024-02-11 15:13:12.776350205 +0000 UTC m=+715318.343120096: ☑️ agreed by AilinKid.
2024-02-26 10:25:09.85847818 +0000 UTC m=+871198.606101288: ☑️ agreed by okJiang.

hawkingrei · 2024-03-07T07:27:55Z

/retest

winoros · 2024-03-07T18:16:42Z

/retest

hawkingrei · 2024-03-13T13:44:11Z

/retest

winoros · 2024-03-18T20:21:26Z

/retest

winoros · 2024-03-29T17:23:23Z

/retest

winoros · 2024-07-19T09:14:02Z

/hold for a while

winoros · 2024-07-19T15:06:42Z

pkg/executor/infoschema_reader.go

@@ -308,7 +308,8 @@ func (e *memtableRetriever) setDataForVariablesInfo(ctx sessionctx.Context) erro

 func (e *memtableRetriever) setDataForUserAttributes(ctx context.Context, sctx sessionctx.Context) error {
 	exec := sctx.GetRestrictedSQLExecutor()
-	chunkRows, _, err := exec.ExecRestrictedSQL(ctx, nil, `SELECT user, host, JSON_UNQUOTE(JSON_EXTRACT(user_attributes, '$.metadata')) FROM mysql.user`)
+	wrappedCtx := kv.WithInternalSourceType(ctx, kv.InternalTxnOthers)


It's a missed one. Found by the intest tag.

winoros · 2024-07-19T15:26:01Z

Now that the check_dev can pass.
We know that the failure is caused by

I'm trying to solve it without enlarging the cache size too much.

…eck-bin

Signed-off-by: AilinKid <314806019@qq.com>

winoros · 2024-07-31T11:16:33Z

/retest

D3Hunter

can you separate the flags which is used for UT/FT and changes normal code path and the flag to control whether enable asserts which is harmless. i don't like the idea that we have to use 2 flags to do it for UT/FT

ti-chi-bot · 2024-08-12T05:51:44Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

… add-test-tag-for-check-bin

winoros · 2024-09-11T15:34:56Z

pkg/planner/core/operator/logicalop/logical_join.go

+	lSchema := lChild.Schema()
+	rSchema := rChild.Schema()
+	// parentused col = t2.a
+	// leftChild schema = t1.a(t2.a) + and others
+	// rightChild schema = t3 related + and others
+	if join, ok := lChild.(*LogicalJoin); ok {
+		if join.FullSchema != nil {
+			lSchema = join.FullSchema
+		}
+	}
+	if join, ok := rChild.(*LogicalJoin); ok {
+		if join.FullSchema != nil {
+			rSchema = join.FullSchema
+		}
+	}
 	for _, col := range parentUsedCols {
-		if lChild.Schema().Contains(col) {
+		if lSchema != nil && lSchema.Contains(col) {
 			leftCols = append(leftCols, col)
-		} else if rChild.Schema().Contains(col) {
+		} else if rSchema != nil && rSchema.Contains(col) {


Found by integration test.

ti-chi-bot · 2024-09-11T16:29:28Z

@winoros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-br-integration-test	`9301a21`	link	true	`/test pull-br-integration-test`
pull-lightning-integration-test	`9301a21`	link	true	`/test pull-lightning-integration-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot · 2024-09-18T17:46:57Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, lance6716, Leavrth, okJiang
Once this PR has been reviewed and has the lgtm label, please assign zanmato1984 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,Leavrth,hawkingrei,lance6716,okJiang]
pkg/expression/OWNERS
~~pkg/planner/OWNERS~~ [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Makefile: add gotag for make server_check

d67f9ea

winoros added the skip-issue-check Indicates that a PR no need to check linked issue. label Feb 7, 2024

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2024

AilinKid approved these changes Feb 11, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm labels Feb 11, 2024

okJiang approved these changes Feb 26, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm labels Feb 26, 2024

winoros added 3 commits July 19, 2024 14:05

Merge branch 'master' into add-test-tag-for-check-bin

1dec276

fix missed internal source type

cb95d45

enlarge the mem limit

38b996e

ti-chi-bot bot added sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2024

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024

test the cache size

2c86f2f

winoros commented Jul 19, 2024

View reviewed changes

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2024

winoros and others added 2 commits July 30, 2024 02:41

Merge remote-tracking branch 'origin/master' into add-test-tag-for-ch…

0a494bf

…eck-bin

quick fix with detect full schema downward

be6f387

Signed-off-by: AilinKid <314806019@qq.com>

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2024

lance6716 approved these changes Jul 31, 2024

View reviewed changes

Update comment thrown in testkit.go

b6bfa46

Leavrth approved these changes Jul 31, 2024

View reviewed changes

winoros mentioned this pull request Jul 31, 2024

get started: add some docs for tidb's integration test pingcap/tidb-dev-guide#259

Merged

D3Hunter reviewed Aug 5, 2024

View reviewed changes

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024

winoros added 2 commits September 11, 2024 23:04

Merge branch 'master' into add-test-tag-for-check-bin

99884e5

address comments

be4c1c9

winoros force-pushed the add-test-tag-for-check-bin branch from 6a35932 to cd55796 Compare September 11, 2024 15:31

Merge remote-tracking branch 'yiding/add-test-tag-for-check-bin' into…

532f689

… add-test-tag-for-check-bin

winoros force-pushed the add-test-tag-for-check-bin branch from cd55796 to 532f689 Compare September 11, 2024 15:32

winoros commented Sep 11, 2024

View reviewed changes

fix bazel file

b58586d

winoros force-pushed the add-test-tag-for-check-bin branch from 9301a21 to b58586d Compare September 11, 2024 15:38

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2024

fix make check

23df741

fix

e3c8c17

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 11, 2024

Merge branch 'master' into add-test-tag-for-check-bin

201d828

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Makefile: add gotag for make server_check #51057

Makefile: add gotag for make server_check #51057

winoros commented Feb 7, 2024

codecov bot commented Feb 7, 2024 •

edited

Loading

winoros commented Feb 8, 2024

winoros commented Feb 18, 2024

okJiang left a comment

ti-chi-bot bot commented Feb 26, 2024

hawkingrei commented Mar 7, 2024

winoros commented Mar 7, 2024

hawkingrei commented Mar 13, 2024

winoros commented Mar 18, 2024

winoros commented Mar 29, 2024

winoros commented Jul 19, 2024

winoros Jul 19, 2024

winoros commented Jul 19, 2024

winoros commented Jul 31, 2024

D3Hunter left a comment

ti-chi-bot bot commented Aug 12, 2024

winoros Sep 11, 2024

ti-chi-bot bot commented Sep 11, 2024 •

edited

Loading

ti-chi-bot bot commented Sep 18, 2024

Makefile: add gotag for make server_check #51057

Are you sure you want to change the base?

Makefile: add gotag for make server_check #51057

Conversation

winoros commented Feb 7, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

codecov bot commented Feb 7, 2024 • edited Loading

Codecov Report

winoros commented Feb 8, 2024

winoros commented Feb 18, 2024

okJiang left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

hawkingrei commented Mar 7, 2024

winoros commented Mar 7, 2024

hawkingrei commented Mar 13, 2024

winoros commented Mar 18, 2024

winoros commented Mar 29, 2024

winoros commented Jul 19, 2024

winoros Jul 19, 2024

Choose a reason for hiding this comment

winoros commented Jul 19, 2024

winoros commented Jul 31, 2024

D3Hunter left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Aug 12, 2024

winoros Sep 11, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 11, 2024 • edited Loading

ti-chi-bot bot commented Sep 18, 2024

codecov bot commented Feb 7, 2024 •

edited

Loading

ti-chi-bot bot commented Sep 11, 2024 •

edited

Loading