Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade go1.23.1 #51126

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

*: upgrade go1.23.1 #51126

wants to merge 10 commits into from

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 18, 2024

What problem does this PR solve?

Issue Number: close #50765

#55480

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 73.30317% with 59 lines in your changes missing coverage. Please review.

Project coverage is 72.9545%. Comparing base (fd6d5c1) to head (60e1510).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51126        +/-   ##
================================================
- Coverage   72.9586%   72.9545%   -0.0041%     
================================================
  Files          1611       1611                
  Lines        447503     447510         +7     
================================================
- Hits         326492     326479        -13     
- Misses       100919     100942        +23     
+ Partials      20092      20089         -3     
Flag Coverage Δ
unit 72.0619% <73.3031%> (-0.0044%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <0.0000%> (ø)
parser ∅ <ø> (∅)
br 45.7986% <100.0000%> (+0.0101%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Feb 18, 2024
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the go1220bazel branch 3 times, most recently from f5577d4 to cca379b Compare March 5, 2024 02:23
@hawkingrei hawkingrei changed the title *: upgrade go1.22.0 *: upgrade go1.22.1 Mar 6, 2024
@hawkingrei hawkingrei force-pushed the go1220bazel branch 2 times, most recently from a3f67d4 to a565307 Compare March 13, 2024 01:46
@purelind
Copy link
Contributor

/hold

Waiting for the evaluation confirmation of @yudongusa and @bb7133 .

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@hawkingrei
Copy link
Member Author

hawkingrei commented Mar 13, 2024

/unhold

wait for CI all green

@hawkingrei hawkingrei removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@hawkingrei hawkingrei force-pushed the go1220bazel branch 2 times, most recently from e489e7f to 3637d26 Compare March 28, 2024 02:59
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024
@hawkingrei hawkingrei changed the title *: upgrade go1.22.1 *: upgrade go1.22.2 Apr 6, 2024
@hawkingrei hawkingrei force-pushed the go1220bazel branch 3 times, most recently from 4898fc9 to 8335af5 Compare August 23, 2024 06:29
Copy link

ti-chi-bot bot commented Aug 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 08:29:55.892350428 +0000 UTC m=+864284.639973554: ☑️ agreed by dveeden.
  • 2024-08-23 07:01:33.785343406 +0000 UTC m=+508088.919793527: ☑️ agreed by lance6716.

@hawkingrei hawkingrei force-pushed the go1220bazel branch 2 times, most recently from c1ce3e7 to 68b81aa Compare September 4, 2024 06:40
@hawkingrei hawkingrei changed the title *: upgrade go1.23.0 *: upgrade go1.23.1 Sep 6, 2024
@hawkingrei hawkingrei force-pushed the go1220bazel branch 3 times, most recently from 0c4b3ba to 2eac3fd Compare September 10, 2024 15:48
Copy link

ti-chi-bot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dveeden, lance6716
Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei and additionally assign benjamin2037, leavrth, tangenta, tiancaiamao, windtalker for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei hawkingrei force-pushed the go1220bazel branch 2 times, most recently from 61ffb43 to e17e095 Compare September 17, 2024 15:11
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

tiprow bot commented Sep 18, 2024

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 60e1510 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Sep 18, 2024

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 60e1510 link true /test pull-br-integration-test
idc-jenkins-ci-tidb/check_dev_2 60e1510 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 60e1510 link true /test check-dev
pull-integration-ddl-test 60e1510 link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/mysql-test 60e1510 link true /test mysql-test
pull-mysql-client-test 60e1510 link true /test pull-mysql-client-test
pull-lightning-integration-test 60e1510 link true /test pull-lightning-integration-test
idc-jenkins-ci-tidb/build 60e1510 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dumpling This is related to Dumpling of TiDB. lgtm ok-to-test release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade go 1.22
4 participants