Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: make test TestRenameTableAutoIDs more stable #54695

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #53765

Problem Summary:

What changed and how does it work?

The root cause is the same with this one #54447
When we do ddl, wait ddl status change to finish is not enough.
We need to wait the infoschema reload finish, otherwise we may see the stale infoschema.

Here the test code execute renamte table renametableautoids.t to renametableautoids2.t2
Using the stale infoschema would get error :

        	Error:      	Received unexpected error:
        	            	[schema:1146]Table 'renametableautoids2.t2' doesn't exist
        	            	github.com/pingcap/errors.AddStack
        	            		external/com_github_pingcap_errors/errors.go:178

NOTE, rename table cross different DBs have known capatibility issue with autoid.
And even after this fix, the test may still be unstable by that capability issue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 17, 2024
@tiancaiamao tiancaiamao requested a review from mjonss July 17, 2024 13:24
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 17, 2024
Copy link

tiprow bot commented Jul 17, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.8626%. Comparing base (c4fd1b2) to head (e76b08b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54695         +/-   ##
=================================================
- Coverage   72.7411%   55.8626%   -16.8786%     
=================================================
  Files          1551       1672        +121     
  Lines        437183     609368     +172185     
=================================================
+ Hits         318012     340409      +22397     
- Misses        99532     245721     +146189     
- Partials      19639      23238       +3599     
Flag Coverage Δ
integration 36.9138% <ø> (?)
unit 71.7094% <ø> (-0.0451%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5834% <ø> (+6.7430%) ⬆️

@tiancaiamao
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jul 18, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/ddl/schema_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jul 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-18 03:20:35.92789411 +0000 UTC m=+496857.918835565: ☑️ agreed by xhebox.
  • 2024-07-18 04:41:30.601622077 +0000 UTC m=+501712.592563547: ☑️ agreed by mjonss.

Copy link

ti-chi-bot bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tangenta, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1c078a0 into pingcap:master Jul 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestRenameTableAutoIDs
4 participants