Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] lightning: store read bytes in compressReader #54808

Closed
wants to merge 3 commits into from

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Jul 22, 2024

What problem does this PR solve?

Issue Number: close #53587 #53655

What changed and how does it work?

Maintain read bytes in readBytes

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2024
Copy link

ti-chi-bot bot commented Jul 22, 2024

Hi @joechenrh. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jul 22, 2024

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
Copy link
Contributor

/ok-to-test

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.4866%. Comparing base (4371a1d) to head (7abe00e).

Current head 7abe00e differs from pull request most recent head bcaa762

Please upload reports for the commit bcaa762 to get more accurate results.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54808         +/-   ##
=================================================
- Coverage   72.9081%   57.4866%   -15.4215%     
=================================================
  Files          1604       1707        +103     
  Lines        446872     635107     +188235     
=================================================
+ Hits         325806     365102      +39296     
- Misses       101016     245228     +144212     
- Partials      20050      24777       +4727     
Flag Coverage Δ
integration 39.8116% <84.6153%> (?)
unit 71.7754% <84.6153%> (-0.2472%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (+0.0088%) ⬆️
parser ∅ <ø> (∅)
br 63.5341% <84.6153%> (+17.7293%) ⬆️

@joechenrh
Copy link
Contributor Author

/retest-required

@joechenrh joechenrh changed the title lightning: store read bytes in compressReader [WIP] lightning: store read bytes in compressReader Jul 23, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2024
@joechenrh
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Aug 2, 2024

@joechenrh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 7abe00e link true /test fast_test_tiprow
tidb_parser_test 7abe00e link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joechenrh joechenrh marked this pull request as draft August 12, 2024 05:30
Copy link

ti-chi-bot bot commented Sep 4, 2024

@joechenrh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lightning-integration-test 7abe00e link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yujuncen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance6716 lance6716 closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import large zstd files may encounter error
2 participants