Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add metrics for instance plan cache eviction #55367

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 12, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: add metrics for instance plan cache eviction

What changed and how does it work?

planner: add metrics for instance plan cache eviction

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/planner SIG: Planner labels Aug 12, 2024
Copy link

tiprow bot commented Aug 12, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Aug 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-12 08:48:39.885973599 +0000 UTC m=+171404.589443243: ☑️ agreed by hawkingrei.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.3087%. Comparing base (89bb81b) to head (73253fd).
Report is 3 commits behind head on master.

Current head 73253fd differs from pull request most recent head 866c915

Please upload reports for the commit 866c915 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55367        +/-   ##
================================================
+ Coverage   74.7608%   75.3087%   +0.5479%     
================================================
  Files          1576       1580         +4     
  Lines        365527     441622     +76095     
================================================
+ Hits         273271     332580     +59309     
- Misses        72453      88440     +15987     
- Partials      19803      20602       +799     
Flag Coverage Δ
integration 50.2096% <45.0000%> (?)
unit 71.8491% <87.5000%> (-1.8719%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 62.2205% <ø> (+14.5634%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 13, 2024
Copy link

ti-chi-bot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hawkingrei
Once this PR has been reviewed and has the lgtm label, please assign easonn7, lance6716 for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2024
Copy link

ti-chi-bot bot commented Aug 13, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Sep 4, 2024

@qw4990: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 866c915 link true /test unit-test
idc-jenkins-ci-tidb/mysql-test 866c915 link true /test mysql-test
idc-jenkins-ci-tidb/build 866c915 link true /test build
pull-br-integration-test 866c915 link true /test pull-br-integration-test
pull-integration-ddl-test 866c915 link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/check_dev 866c915 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 866c915 link true /test check-dev2
pull-mysql-client-test 866c915 link true /test pull-mysql-client-test
pull-lightning-integration-test 866c915 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-1-more-lgtm needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants