Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: make tidb_enable_stats_owner controlling the stats owner #55592

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 22, 2024

What problem does this PR solve?

Issue Number: close #55989

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

if disable this variable, you cannot find the auto-analyze stack in the profiler.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

config: make tidb_enable_ddl controlling the stats owner

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2024
@hawkingrei hawkingrei changed the title config: make tidb_enable_ddl controlling the ddl owner config: make tidb_enable_ddl controlling the stats owner Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 48.88889% with 23 lines in your changes missing coverage. Please review.

Project coverage is 56.9858%. Comparing base (e5aad02) to head (3c1ed2a).
Report is 20 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55592         +/-   ##
=================================================
- Coverage   72.9147%   56.9858%   -15.9290%     
=================================================
  Files          1605       1756        +151     
  Lines        446513     633440     +186927     
=================================================
+ Hits         325574     360971      +35397     
- Misses       100899     247665     +146766     
- Partials      20040      24804       +4764     
Flag Coverage Δ
integration 39.4638% <40.0000%> (?)
unit 72.0010% <48.8888%> (-0.0340%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0409% <ø> (+17.2933%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Sep 10, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the make_make_ddl_control_stats_owner branch from c960d44 to 4114295 Compare September 10, 2024 12:21
@lance6716
Copy link
Contributor

please involve a PM review

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Sep 11, 2024

please involve a PM review

PM have known it and agree with it.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@lance6716
Copy link
Contributor

need to update PR title

@hawkingrei hawkingrei changed the title config: make tidb_enable_ddl controlling the stats owner config: make tidb_enable_stats_owner controlling the stats owner Sep 11, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2024
pkg/domain/domain.go Outdated Show resolved Hide resolved
Co-authored-by: Yiding Cui <winoros@gmail.com>
Copy link

ti-chi-bot bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance6716, winoros
Once this PR has been reviewed and has the lgtm label, please assign yudongusa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-11 08:02:41.820352539 +0000 UTC m=+429831.560776470: ☑️ agreed by lance6716.
  • 2024-09-11 11:04:28.377230494 +0000 UTC m=+440738.117654433: ☑️ agreed by winoros.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

2 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

pkg/domain/domain.go Outdated Show resolved Hide resolved
pkg/domain/domain.go Outdated Show resolved Hide resolved
pkg/domain/domain.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

tiprow bot commented Sep 13, 2024

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 3faf1e2 link true /test tidb_parser_test
fast_test_tiprow 3faf1e2 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@lance6716
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use tidb_enable_stats_owner to Control the Stats Owner
3 participants