br/stream: Added toolkit for managing migrations #55665
Conversation
ti-chi-bot
bot
added
do-not-merge/invalid-title
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/XXL
YuJuncen
changed the title
|
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
YuJuncen
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55665 +/- ##
=================================================
- Coverage 72.8489% 56.3302% -16.5188%
=================================================
Files 1604 1755 +151
Lines 445733 629786 +184053
=================================================
+ Hits 324712 354760 +30048
- Misses 101000 250345 +149345
- Partials 20021 24681 +4660
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
make bazel prepare Signed-off-by: hillium <yujuncen@pingcap.com> fix linters Signed-off-by: hillium <yujuncen@pingcap.com> try fix the test case Signed-off-by: hillium <yujuncen@pingcap.com>
YuJuncen
force-pushed
the
mig-truncating-split2
branch
from
095f623
to
e183b20
Compare
Signed-off-by: hillium <yujuncen@pingcap.com>
|
@YuJuncen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| err := os.Remove(path) | ||
| if err != nil && | ||
| l.IgnoreEnoentForDelete && | ||
| stderrors.Is(err, syscall.ENOENT) { |
There was a problem hiding this comment.
local external storage also support windows, so can syscall.ENOENT also match the error occur in windows system?
| HandingMetaEditDone() | ||
| } | ||
|
|
||
| func NewProgressBarHooks(console glue.ConsoleOperations) *ProgressBarHooks { |
There was a problem hiding this comment.
is it dead code? or will be called outside?
|
|
||
| me := new(pb.MetaEdit) | ||
| me.Path = path | ||
| for _, ds := range meta.FileGroups { |
There was a problem hiding this comment.
should we also append the me.DeleteLogicalFiles because m.applyMetaEditTo uses it?
|
|
||
| // MergeAndMigrateTo will merge the migrations from BASE until the specified SN, then migrate to it. | ||
| // Finally it writes the new BASE and remove stale migrations from the storage. | ||
| func (m MigrationExt) MergeAndMigrateTo( |
There was a problem hiding this comment.
I found there are many functions only used in unit test, so I prefer to move these functions to another file with suffix _test.go to read and check codes for production more clearly.
What problem does this PR solve?
Issue Number: close #55661
Problem Summary:
See the issue.
What changed and how does it work?
We added some new interfaces that helps to manipulate migrations. They are provided by a wrapper over
ExternalStoragenamedMigrationExt.MergeAndMigrateTois the main interface for executing pending migrations.Loadloads the persisted migrations.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.