*: move XXInfo/Job, etc, out from model pkg in parser to meta #55754

D3Hunter · 2024-08-29T14:29:38Z

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

following PR of *: move annotated attributes of AST node to resolve.Context #55634, we move XXInfo/Job, etc, out from model pkg of parser to meta, also split it into different files
some structs like CIStr is kept in parser/model to keep compatible with older version, will move them to ast pkg later

Check List

Tests

Unit test, only move code, reusing existing cases
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

change other model change change to meta model parser

tiprow · 2024-08-29T14:30:02Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-08-29T15:20:18Z

Codecov Report

Attention: Patch coverage is 96.25668% with 14 lines in your changes missing coverage. Please review.

Project coverage is 57.1025%. Comparing base (0583e84) to head (ccf71f4).
Report is 9 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #55754         +/-   ##
=================================================
- Coverage   72.7958%   57.1025%   -15.6933%     
=================================================
  Files          1588       1748        +160     
  Lines        443469     631574     +188105     
=================================================
+ Hits         322827     360645      +37818     
- Misses       100772     246003     +145231     
- Partials      19870      24926       +5056

Flag	Coverage Δ
integration	`39.5556% <81.4016%> (?)`
unit	`71.9101% <88.2352%> (+0.0035%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9567% <100.0000%> (ø)`
parser	`∅ <ø> (∅)`
br	`62.9097% <100.0000%> (+17.4785%)`	⬆️

D3Hunter · 2024-08-29T14:50:35Z

pkg/parser/ast/ddl.go

@@ -2302,29 +2302,21 @@ func (n *ResourceGroupOption) Restore(ctx *format.RestoreCtx) error {
 	return nil
 }

-type RunawayOptionType int


this type is redefined in model/model.go, introduced in #43843

see
https://github.com/pingcap/tidb/pull/43843/files#diff-ee2e401594b744a2daae48119d71fdff0022c3a59b58eaf30a12e37009eede60R2187-R2193
and https://github.com/pingcap/tidb/pull/43843/files#diff-798c1c7a69a59b2fba339f230d6b764dbffe9ddc80cff6eb526139f621f7c225R1885-R1891

D3Hunter · 2024-08-30T00:31:39Z

/retest

tiprow · 2024-08-30T00:31:59Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2024-08-30T08:32:09Z

[LGTM Timeline notifier]

Timeline:

2024-08-30 01:47:40.157213433 +0000 UTC m=+1094055.291663555: ☑️ agreed by lance6716.
2024-08-30 08:32:08.5942795 +0000 UTC m=+1253.112332424: ☑️ agreed by joccau.

windtalker

lgtm

lcwangchao

If you move model pkg out of parser, I'm not sure whether some other repos that depencies on the parser will break...

@bb7133 could you take a look?

D3Hunter · 2024-09-03T01:43:15Z

If you move model pkg out of parser, I'm not sure whether some other repos that depencies on the parser will break...

@bb7133 could you take a look?

I checked some outer dependency of parser, they only depends on AST and model.CIStr, those part are not moved. I have already described it in the PR, ptal

yudongusa

LGTM.

ti-chi-bot · 2024-09-03T06:05:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, hawkingrei, joccau, lance6716, lcwangchao, tangenta, tiancaiamao, windtalker, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [3pointer,hawkingrei,joccau,lance6716,lcwangchao,tangenta,tiancaiamao,windtalker]
~~br/OWNERS~~ [3pointer]
~~dumpling/OWNERS~~ [lance6716,tangenta]
~~lightning/OWNERS~~ [lance6716]
~~pkg/autoid_service/OWNERS~~ [tiancaiamao]
~~pkg/bindinfo/OWNERS~~ [hawkingrei]
~~pkg/ddl/OWNERS~~ [lance6716,tangenta]
~~pkg/distsql/OWNERS~~ [windtalker]
~~pkg/disttask/OWNERS~~ [lance6716,tangenta]
~~pkg/domain/OWNERS~~ [lance6716,tangenta]
~~pkg/executor/importer/OWNERS~~ [lance6716]
~~pkg/expression/OWNERS~~ [windtalker]
~~pkg/infoschema/OWNERS~~ [tangenta]
~~pkg/lightning/OWNERS~~ [lance6716]
~~pkg/lock/OWNERS~~ [lance6716,tangenta]
~~pkg/meta/OWNERS~~ [tangenta]
~~pkg/parser/OWNERS~~ [tangenta,yudongusa]
~~pkg/planner/OWNERS~~ [hawkingrei]
~~pkg/sessionctx/variable/OWNERS~~ [yudongusa]
~~pkg/statistics/OWNERS~~ [hawkingrei]
~~pkg/table/OWNERS~~ [tangenta]
~~pkg/tablecodec/OWNERS~~ [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

D3Hunter · 2024-09-03T08:07:28Z

/retest

tiprow · 2024-09-03T08:07:50Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-03T09:26:36Z

/retest

tiprow · 2024-09-03T09:27:01Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-04T03:32:33Z

/test pull-lightning-integration-test

tiprow · 2024-09-04T03:32:54Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

change

70dea9e

change other model change change to meta model parser

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-title component/dumpling This is related to Dumpling of TiDB. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 29, 2024

D3Hunter added 2 commits August 29, 2024 22:51

change

a9b4363

lint

f2d5012

D3Hunter added 3 commits August 30, 2024 00:16

change

6d19bbb

change

e55266d

change

7e3de90

D3Hunter commented Aug 29, 2024

View reviewed changes

D3Hunter added 2 commits August 30, 2024 02:37

change

db32102

change

0f855d4

D3Hunter changed the title ~~[WIPMove job structs~~ [WIP]*: move model pkg in parser to meta Aug 29, 2024

ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/invalid-title labels Aug 29, 2024

change

abc6af9

D3Hunter changed the title ~~[WIP]*: move model pkg in parser to meta~~ *: move model pkg in parser to meta Aug 30, 2024

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2024

lance6716 approved these changes Aug 30, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm label Aug 30, 2024

joccau approved these changes Aug 30, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm labels Aug 30, 2024

windtalker approved these changes Sep 2, 2024

View reviewed changes

D3Hunter added 3 commits September 2, 2024 17:50

Merge remote-tracking branch 'upstream/master' into move-job-structs

f745c22

bazel

6568b32

bazel

b71f6c3

hawkingrei approved these changes Sep 2, 2024

View reviewed changes

3pointer approved these changes Sep 2, 2024

View reviewed changes

tiancaiamao approved these changes Sep 2, 2024

View reviewed changes

tangenta approved these changes Sep 2, 2024

View reviewed changes

lcwangchao reviewed Sep 3, 2024

View reviewed changes

lcwangchao approved these changes Sep 3, 2024

View reviewed changes

D3Hunter changed the title *: move model pkg in parser to meta *: move XXInfo/Job, etc, out from model pkg in parser to meta Sep 3, 2024

D3Hunter mentioned this pull request Sep 3, 2024

ddl code refactor/optimize #54436

Open

53 tasks

yudongusa approved these changes Sep 3, 2024

View reviewed changes

ti-chi-bot bot added the approved label Sep 3, 2024

Merge remote-tracking branch 'upstream/master' into move-job-structs

a5cde8a

fix conflict

649e37f

D3Hunter added 2 commits September 3, 2024 16:55

Merge remote-tracking branch 'upstream/master' into move-job-structs

1e0a361

fix conflict

ccf71f4

ti-chi-bot bot merged commit 3176b9c into pingcap:master Sep 4, 2024
27 checks passed

D3Hunter deleted the move-job-structs branch September 4, 2024 05:08

tangenta mentioned this pull request Sep 9, 2024

*: support for adding/dropping vector index | tidb-test=723d2370f1b3956d22a5ab87b1fc8b9b864ca051 #55839

Merged

13 tasks

D3Hunter mentioned this pull request Sep 19, 2024

meta: export some deprecated action types for cdc #56170

Open

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: move XXInfo/Job, etc, out from model pkg in parser to meta #55754

*: move XXInfo/Job, etc, out from model pkg in parser to meta #55754

D3Hunter commented Aug 29, 2024 •

edited

Loading

tiprow bot commented Aug 29, 2024

codecov bot commented Aug 29, 2024 •

edited

Loading

D3Hunter Aug 29, 2024

D3Hunter commented Aug 30, 2024

tiprow bot commented Aug 30, 2024

ti-chi-bot bot commented Aug 30, 2024

windtalker left a comment

lcwangchao left a comment

D3Hunter commented Sep 3, 2024

yudongusa left a comment

ti-chi-bot bot commented Sep 3, 2024

D3Hunter commented Sep 3, 2024

tiprow bot commented Sep 3, 2024

D3Hunter commented Sep 3, 2024

tiprow bot commented Sep 3, 2024

D3Hunter commented Sep 4, 2024

tiprow bot commented Sep 4, 2024

*: move XXInfo/Job, etc, out from model pkg in parser to meta #55754

*: move XXInfo/Job, etc, out from model pkg in parser to meta #55754

Conversation

D3Hunter commented Aug 29, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Aug 29, 2024

codecov bot commented Aug 29, 2024 • edited Loading

Codecov Report

D3Hunter Aug 29, 2024

Choose a reason for hiding this comment

D3Hunter commented Aug 30, 2024

tiprow bot commented Aug 30, 2024

ti-chi-bot bot commented Aug 30, 2024

[LGTM Timeline notifier]

windtalker left a comment

Choose a reason for hiding this comment

lcwangchao left a comment

Choose a reason for hiding this comment

D3Hunter commented Sep 3, 2024

yudongusa left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 3, 2024

D3Hunter commented Sep 3, 2024

tiprow bot commented Sep 3, 2024

D3Hunter commented Sep 3, 2024

tiprow bot commented Sep 3, 2024

D3Hunter commented Sep 4, 2024

tiprow bot commented Sep 4, 2024

D3Hunter commented Aug 29, 2024 •

edited

Loading

codecov bot commented Aug 29, 2024 •

edited

Loading