-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: add log backup/restore encryption support #55757
base: master
Are you sure you want to change the base?
br: add log backup/restore encryption support #55757
Conversation
Skipping CI for Draft Pull Request. |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c71db0e
to
75683ad
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
75683ad
to
fe51422
Compare
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
fe51422
to
a1d18e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55757 +/- ##
================================================
+ Coverage 72.8979% 73.4732% +0.5752%
================================================
Files 1611 1653 +42
Lines 447376 456106 +8730
================================================
+ Hits 326128 335116 +8988
+ Misses 101176 100229 -947
- Partials 20072 20761 +689
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@Tristan1900: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
||
calculate_checksum() { | ||
local db=$1 | ||
local checksum=$(run_sql "USE $db; ADMIN CHECKSUM TABLE $TABLE;" | awk '/CHECKSUM/{print $2}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
table id might change so checksum should fail?
restart_services || { echo "Failed to restart services"; exit 1; } | ||
|
||
# Drop databases before restoring | ||
drop_db || { echo "Failed to drop databases before restore"; exit 1; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this, and check if db is empty
What problem does this PR solve?
Issue Number: close #55834
Problem Summary:
What changed and how does it work?
For example:
or
master key can be kms from cloud vendors
For restore
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.