ddl: args v2 for create/drop/modify schema #55919
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55919 +/- ##
=================================================
- Coverage 72.9281% 57.3235% -15.6047%
=================================================
Files 1605 1755 +150
Lines 446061 633534 +187473
=================================================
+ Hits 325304 363164 +37860
- Misses 100689 245548 +144859
- Partials 20068 24822 +4754
Flags with carried forward coverage won't be shown. Click here to find out more.
|
D3Hunter
force-pushed
the
args-c-d-schema
branch
from
1e557e8
to
5b1ef8a
Compare
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
change add assert change change change modify schema charset/collate change change lint lint fix test change remove useless code fix change rename change change change change change change
D3Hunter
force-pushed
the
args-c-d-schema
branch
from
70bbb58
to
1e2b25a
Compare
D3Hunter
changed the title
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
| if len(job.Args) > 0 { | ||
| arg = job.Args[0] | ||
| } | ||
| job.RawArgs, err = json.Marshal(arg) |
There was a problem hiding this comment.
if can moved inside if len(job.Args) > 0? And do you think we should assert len(job.Args) == 1
There was a problem hiding this comment.
no, we need Marshal nil to clear args out
And do you think we should assert len(job.Args) == 1
added in another PR, https://github.com/pingcap/tidb/pull/55964/files#diff-c51ad6b394f865592721a3e18d58574176394570e3efcff7703e8bd0c3c5c2efR518
| // FinishedJobArgs is the interface for finished job arguments. | ||
| // in most cases, job args are cleared out after the job is finished, but some jobs | ||
| // will write some args back to the job for other components. | ||
| type FinishedJobArgs interface { |
There was a problem hiding this comment.
| type FinishedJobArgs interface { | |
| type finishedJobArgs interface { |
There was a problem hiding this comment.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #53930
Problem Summary:
What changed and how does it work?
create-schema/drop-schema/modify schema charset or collate/modify schema placementFinishedJobArgsinterface for jobs that need to save some info after job finishCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.