Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statstics: increase the synchronization offset size when to sync stats (#55943) #55960

Merged
merged 2 commits into from
Sep 9, 2024
Merged

statstics: increase the synchronization offset size when to sync stats (#55943) #55960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e5817c
This is an automated cherry-pick of #55943
hawkingrei Sep 9, 2024
70d7afd
test
hawkingrei Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions statistics/handle/handle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,8 +571,8 @@ func (h *Handle) Update(is infoschema.InfoSchema, opts ...TableStatsOpt) error {
// Consider the case that there are two tables A and B, their version and commit time is (A0, A1) and (B0, B1),
// and A0 < B0 < B1 < A1. We will first read the stats of B, and update the lastVersion to B0, but we cannot read
// the table stats of A0 if we read stats that greater than lastVersion which is B0.
// We can read the stats if the diff between commit time and version is less than three lease.
offset := DurationToTS(3 * h.Lease())
// We can read the stats if the diff between commit time and version is less than five lease.
offset := DurationToTS(5 * h.Lease()) // 5 lease is 15s.
if oldCache.version >= offset {
lastVersion = lastVersion - offset
} else {
Expand Down
Loading