Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: args v2 for create table/view/sequence, batch create table #55964

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Sep 9, 2024

What problem does this PR solve?

Issue Number: ref #53930

Problem Summary:

What changed and how does it work?

  • args v2 for create table/view/sequence, and batch create table
  • add JobArgs into JobWrapper, so we can use it directly at job_submitter/executor part, in this PR i only changed new added ones, will change existing job args later

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2024
Copy link

tiprow bot commented Sep 9, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 13 lines in your changes missing coverage. Please review.

Project coverage is 56.7988%. Comparing base (fa8fd91) to head (1b9f51c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55964         +/-   ##
=================================================
- Coverage   72.9481%   56.7988%   -16.1493%     
=================================================
  Files          1609       1761        +152     
  Lines        447196     630633     +183437     
=================================================
+ Hits         326221     358192      +31971     
- Misses       100896     247691     +146795     
- Partials      20079      24750       +4671     
Flag Coverage Δ
integration 39.4793% <78.2051%> (?)
unit 72.0124% <94.0170%> (-0.0443%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0524% <ø> (+17.2504%) ⬆️

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 9, 2024

/retest

Copy link

tiprow bot commented Sep 9, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 9, 2024

/retest

Copy link

tiprow bot commented Sep 9, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 9, 2024

/retest

Copy link

tiprow bot commented Sep 9, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

create tbl/seq

change

todo

change

ut

test

change

fix test

test
@D3Hunter D3Hunter changed the title [WIP]ddl: args v2 for create table/view/sequence, batch create table ddl: args v2 for create table/view/sequence, batch create table Sep 10, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2024
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Sep 10, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

ping @lance6716

Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Sep 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joccau, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-14 03:59:27.311090136 +0000 UTC m=+674437.051514068: ☑️ agreed by tangenta.
  • 2024-09-14 06:43:11.456403653 +0000 UTC m=+684261.196827593: ☑️ agreed by joccau.

Copy link

tiprow bot commented Sep 14, 2024

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 1b9f51c link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit b1767ca into pingcap:master Sep 14, 2024
24 of 25 checks passed
@D3Hunter D3Hunter deleted the args-create-drop-tbl branch September 14, 2024 07:09
@D3Hunter D3Hunter mentioned this pull request Sep 14, 2024
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants