Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]ddl: refactor the V2 args of Modifying column ddl job #56047

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

joccau
Copy link
Member

@joccau joccau commented Sep 12, 2024

What problem does this PR solve?

Issue Number: Ref #53930
Ref #54436

Problem Summary:

What changed and how does it work?

As title~

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wjhuang2016 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0.58140% with 171 lines in your changes missing coverage. Please review.

Project coverage is 56.2798%. Comparing base (1dc045f) to head (c1e201e).
Report is 32 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56047         +/-   ##
=================================================
- Coverage   72.9331%   56.2798%   -16.6533%     
=================================================
  Files          1604       1757        +153     
  Lines        446775     634929     +188154     
=================================================
+ Hits         325847     357337      +31490     
- Misses       100854     252898     +152044     
- Partials      20074      24694       +4620     
Flag Coverage Δ
integration 24.8944% <0.5814%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 60.9718% <ø> (+15.2511%) ⬆️

Signed-off-by: joccau <zak.zhao@pingcap.cn>
Signed-off-by: joccau <zak.zhao@pingcap.cn>
Signed-off-by: joccau <zak.zhao@pingcap.com.cn>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 12, 2024
Signed-off-by: joccau <zak.zhao@pingcap.cn>
@joccau
Copy link
Member Author

joccau commented Sep 12, 2024

/cc @joechenrh

Copy link

ti-chi-bot bot commented Sep 12, 2024

@joccau: GitHub didn't allow me to request PR reviews from the following users: joechenrh.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @joechenrh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: joccau <zak.zhao@pingcap.cn>
@joccau joccau changed the title ddl: refactor the arguments of Modifying column ddl job ddl: refactor the V2 args of Modifying column ddl job Sep 13, 2024
@joccau
Copy link
Member Author

joccau commented Sep 13, 2024

/test fast_test_tiprow

Copy link

ti-chi-bot bot commented Sep 13, 2024

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pull-br-integration-test
  • /test pull-integration-ddl-test
  • /test pull-lightning-integration-test
  • /test pull-mysql-client-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test canary-notify-when-compatibility-sections-changed
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-integration-nodejs-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test
  • pingcap/tidb/pull_br_integration_test
  • pingcap/tidb/pull_integration_ddl_test
  • pingcap/tidb/pull_lightning_integration_test
  • pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joechenrh
Copy link
Contributor

/retest

Signed-off-by: joccau <zak.zhao@pingcap.cn>
@joccau
Copy link
Member Author

joccau commented Sep 13, 2024

/retest

Signed-off-by: joccau <zak.zhao@pingcap.cn>
@joccau
Copy link
Member Author

joccau commented Sep 14, 2024

/retest

Copy link

ti-chi-bot bot commented Sep 14, 2024

@joccau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test c1e201e link true /test pull-br-integration-test
pull-mysql-client-test c1e201e link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/mysql-test c1e201e link true /test mysql-test
idc-jenkins-ci-tidb/unit-test c1e201e link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 c1e201e link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

tiprow bot commented Sep 14, 2024

@joccau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow c1e201e link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@D3Hunter
Copy link
Contributor

will review after all test success

@joccau joccau changed the title ddl: refactor the V2 args of Modifying column ddl job [WIP]ddl: refactor the V2 args of Modifying column ddl job Sep 18, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants