-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]ddl: refactor the V2 args of Modifying column ddl job #56047
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56047 +/- ##
=================================================
- Coverage 72.9331% 56.2798% -16.6533%
=================================================
Files 1604 1757 +153
Lines 446775 634929 +188154
=================================================
+ Hits 325847 357337 +31490
- Misses 100854 252898 +152044
- Partials 20074 24694 +4620
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: joccau <zak.zhao@pingcap.cn>
Signed-off-by: joccau <zak.zhao@pingcap.cn>
f9e3767
to
4946cca
Compare
Signed-off-by: joccau <zak.zhao@pingcap.com.cn>
74e18eb
to
9bdf13b
Compare
/cc @joechenrh |
@joccau: GitHub didn't allow me to request PR reviews from the following users: joechenrh. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: joccau <zak.zhao@pingcap.cn>
22c6c4c
to
b43a243
Compare
/test fast_test_tiprow |
@joccau: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Signed-off-by: joccau <zak.zhao@pingcap.cn>
/retest |
Signed-off-by: joccau <zak.zhao@pingcap.cn>
/retest |
@joccau: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@joccau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
will review after all test success |
What problem does this PR solve?
Issue Number: Ref #53930
Ref #54436
Problem Summary:
What changed and how does it work?
As title~
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.