Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: add for update into write to avoid inaccurate results #56055

Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 13, 2024

What problem does this PR solve?

Issue Number: close #56062

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

do concurrency delete/update operate and exchange partition. The count is right.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.3549%. Comparing base (22ef99a) to head (a35ac9d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56055         +/-   ##
=================================================
- Coverage   72.8954%   56.3549%   -16.5406%     
=================================================
  Files          1609       1759        +150     
  Lines        447132     630532     +183400     
=================================================
+ Hits         325939     355336      +29397     
- Misses       101138     250738     +149600     
- Partials      20055      24458       +4403     
Flag Coverage Δ
integration 38.6305% <33.3333%> (?)
unit 72.0151% <100.0000%> (+0.0072%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8622% <ø> (+7.0709%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the add_for_update_when_to_exchange_partition branch from beb79c1 to 1b4aba4 Compare September 13, 2024 16:08
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2024
@hawkingrei
Copy link
Member Author

/retest

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the add_for_update_when_to_exchange_partition branch from 1b4aba4 to 09493a2 Compare September 13, 2024 16:32
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Co-authored-by: you06 <you1474600@gmail.com>
Copy link

ti-chi-bot bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: winoros, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-13 10:17:34.729676804 +0000 UTC m=+610724.470100738: ☑️ agreed by winoros.
  • 2024-09-13 17:06:36.600163525 +0000 UTC m=+635266.340587463: ☑️ agreed by you06.

@ti-chi-bot ti-chi-bot bot merged commit b9a7d35 into pingcap:master Sep 13, 2024
23 of 24 checks passed
@hawkingrei hawkingrei deleted the add_for_update_when_to_exchange_partition branch September 14, 2024 02:02
@hawkingrei
Copy link
Member Author

/cherrypick release-8.1

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 14, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #56086.

In response to this:

/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exchange partition lead to inaccurate stats_meta
4 participants